fix(atomic): hide unhydrated results #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
force-pushed
the
fix/KIT-3775
branch
from
7321c6a to
cffedd0
Compare
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
force-pushed
the
fix/KIT-3775
branch
from
cffedd0 to
e50b0f1
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
force-pushed
the
fix/KIT-3775
branch
from
e50b0f1 to
c2fb466
Compare
louis-bompart
requested review from
mikegron,
dguerinCoveo,
olamothe,
fpbrault,
y-lakhdar and
alexprudhomme
|
This is a corner case, so @lvu285 or @wmannard , I'll ask for your QA validation for this one (this time, and next time when we migrate, then I think it's niche enough that it'll remain fine). Reproduce bug:
Fix showcase:
|
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
commented
Jan 28, 2025
fbeaudoincoveo
approved these changes
Jan 28, 2025
alexprudhomme
approved these changes
Jan 29, 2025
|
Hi @louis-bompart ,
|
lvu285
approved these changes
Feb 4, 2025
louis-bompart
force-pushed
the
fix/KIT-3775
branch
from
c2fb466 to
3543e12
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
I think not, I think I was quit accurate with my CSS so shouldbefine:tm: |
dguerinCoveo
approved these changes
Feb 4, 2025
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3775
Inspired by https://bbellmyers.github.io/2020/09/27/fouc-stencil.html.
Not a definitive fix: When Lit migration is done for the atomic-result, we should validate for regression on that front, and also try to improve the behavior even so slightly.
It might also be preferable to migrate all result components first, so that we can "cut" this behavior neatly. (would likely not happen because I think we scan documentFragment from template element, so we should have all the element defined by then (tho maybe not because of race conditions, in which case https://www.abeautifulsite.net/posts/flash-of-undefined-custom-elements might be adapted for our needs)